[ozone-dev] How do I build all targets with use_ozone enabled?

[Nico Weber]

Hi,

I'm trying to enable -Wimplicit-fallthrough for use_ozone=true builds (it
even finds bugs:
https://chromium-review.googlesource.com/c/chromium/src/+/899984)

So I enabled the warning locally, set use_ozone=true, and ran `ninja -C
out/gnozon`.

However, that seems to build a bunch of targets that aren't supposed to be
built (which is imho a bug; if someone were to clean this up by removing
references to targets that aren't supposed to build in this config from
//BULD.gn that'd be good. I'd file a bug, but I didn't see an "ozone"
component on crbug, so I wasn't sure if anyone would see it).

So then I used what the headless bot uses, which is "headless:headless
headless:headless_browsertests headless:headless_example
headless:headless_shell headless:headless_unittests headless_browsertests
headless_unittests"

However, this didn't build vr_shell, which was one of the targets that does
build and where the warning did find a bug.

How do I build all targets that are supposed to be part of an ozone build?

Thanks,
Nico

[Robert Kroeger]

Ozone is a abstraction layer with multiple backends -- very much like our
GL implementation in some ways. There consequently many targets that use
ozone where each one could use one of several different ozone
implementations. The linux ozone and CrOS ozone bots probably capture the
most targets that use ozone.

Unfortunately, there is no Chrome builder that actually runs all of the
different ozone backends.

Rob.

Post by Nico Weber
Hi,
I'm trying to enable -Wimplicit-fallthrough for use_ozone=true builds (it
even finds bugs: https://chromium-review.googlesource.com/c/chromium/
src/+/899984)
So I enabled the warning locally, set use_ozone=true, and ran `ninja -C
out/gnozon`.
However, that seems to build a bunch of targets that aren't supposed to be
built (which is imho a bug; if someone were to clean this up by removing
references to targets that aren't supposed to build in this config from
//BULD.gn that'd be good. I'd file a bug, but I didn't see an "ozone"
component on crbug, so I wasn't sure if anyone would see it).
So then I used what the headless bot uses, which is "headless:headless
headless:headless_browsertests headless:headless_example
headless:headless_shell headless:headless_unittests headless_browsertests
headless_unittests"
However, this didn't build vr_shell, which was one of the targets that
does build and where the warning did find a bug.
How do I build all targets that are supposed to be part of an ozone build?
Thanks,
Nico

[Nico Weber]

So you're saying that my complaint about "if I build all targets in the
headless config, some don't build" should be sent to the headless team
instead of to this list?

Post by Robert Kroeger
Ozone is a abstraction layer with multiple backends -- very much like our
GL implementation in some ways. There consequently many targets that use
ozone where each one could use one of several different ozone
implementations. The linux ozone and CrOS ozone bots probably capture the
most targets that use ozone.
Unfortunately, there is no Chrome builder that actually runs all of the
different ozone backends.
Rob.

Post by Nico Weber
Hi,
I'm trying to enable -Wimplicit-fallthrough for use_ozone=true builds (it
even finds bugs: https://chromium-review.googlesource.com/c/chromium/sr
c/+/899984)
So I enabled the warning locally, set use_ozone=true, and ran `ninja -C
out/gnozon`.
However, that seems to build a bunch of targets that aren't supposed to
be built (which is imho a bug; if someone were to clean this up by removing
references to targets that aren't supposed to build in this config from
//BULD.gn that'd be good. I'd file a bug, but I didn't see an "ozone"
component on crbug, so I wasn't sure if anyone would see it).
So then I used what the headless bot uses, which is "headless:headless
headless:headless_browsertests headless:headless_example
headless:headless_shell headless:headless_unittests headless_browsertests
headless_unittests"
However, this didn't build vr_shell, which was one of the targets that
does build and where the warning did find a bug.
How do I build all targets that are supposed to be part of an ozone build?
Thanks,
Nico

[Robert Kroeger]

Post by Nico Weber
So you're saying that my complaint about "if I build all targets in the
headless config, some don't build" should be sent to the headless team
instead of to this list?

I apologize for not necessarily replying particularly well.

But yes, that's what I was trying to say. There is an entire headless
Chrome build that has nothing to do with ozone. I think the targets that
you list are from that.

There is also an ozone platform implementation called "headless". It is
unrelated. If you find issues in the ozone platform implementations, you
can assign them to me and I'll direct them appropriately. But issues with
the headless target should go to the headless team.

Rob.

Post by Nico Weber

Post by Robert Kroeger
Ozone is a abstraction layer with multiple backends -- very much like our
GL implementation in some ways. There consequently many targets that use
ozone where each one could use one of several different ozone
implementations. The linux ozone and CrOS ozone bots probably capture the
most targets that use ozone.
Unfortunately, there is no Chrome builder that actually runs all of the
different ozone backends.
Rob.

Post by Nico Weber
Hi,
I'm trying to enable -Wimplicit-fallthrough for use_ozone=true builds
(it even finds bugs: https://chromium-review.
googlesource.com/c/chromium/src/+/899984)
So I enabled the warning locally, set use_ozone=true, and ran `ninja -C
out/gnozon`.
However, that seems to build a bunch of targets that aren't supposed to
be built (which is imho a bug; if someone were to clean this up by removing
references to targets that aren't supposed to build in this config from
//BULD.gn that'd be good. I'd file a bug, but I didn't see an "ozone"
component on crbug, so I wasn't sure if anyone would see it).
So then I used what the headless bot uses, which is "headless:headless
headless:headless_browsertests headless:headless_example
headless:headless_shell headless:headless_unittests headless_browsertests
headless_unittests"
However, this didn't build vr_shell, which was one of the targets that
does build and where the warning did find a bug.
How do I build all targets that are supposed to be part of an ozone build?
Thanks,
Nico

[Nico Weber]

Got it, thanks!

Post by Robert Kroeger

Post by Nico Weber
So you're saying that my complaint about "if I build all targets in the
headless config, some don't build" should be sent to the headless team
instead of to this list?

I apologize for not necessarily replying particularly well.
But yes, that's what I was trying to say. There is an entire headless
Chrome build that has nothing to do with ozone. I think the targets that
you list are from that.
There is also an ozone platform implementation called "headless". It is
unrelated. If you find issues in the ozone platform implementations, you
can assign them to me and I'll direct them appropriately. But issues with
the headless target should go to the headless team.
Rob.

Post by Nico Weber

Post by Robert Kroeger
Ozone is a abstraction layer with multiple backends -- very much like
our GL implementation in some ways. There consequently many targets that
use ozone where each one could use one of several different ozone
implementations. The linux ozone and CrOS ozone bots probably capture the
most targets that use ozone.
Unfortunately, there is no Chrome builder that actually runs all of the
different ozone backends.
Rob.

Post by Nico Weber
Hi,
I'm trying to enable -Wimplicit-fallthrough for use_ozone=true builds
(it even finds bugs: https://chromium-review.
googlesource.com/c/chromium/src/+/899984)
So I enabled the warning locally, set use_ozone=true, and ran `ninja -C
out/gnozon`.
However, that seems to build a bunch of targets that aren't supposed to
be built (which is imho a bug; if someone were to clean this up by removing
references to targets that aren't supposed to build in this config from
//BULD.gn that'd be good. I'd file a bug, but I didn't see an "ozone"
component on crbug, so I wasn't sure if anyone would see it).
So then I used what the headless bot uses, which is "headless:headless
headless:headless_browsertests headless:headless_example
headless:headless_shell headless:headless_unittests headless_browsertests
headless_unittests"
However, this didn't build vr_shell, which was one of the targets that
does build and where the warning did find a bug.
How do I build all targets that are supposed to be part of an ozone build?
Thanks,
Nico

[Wez]

FWIW the is_fuchsia build is also not-yet 'all'-clean (we have
crbug.com/808287 filed to track work toward that).

Post by Nico Weber
Got it, thanks!

Post by Robert Kroeger

Post by Nico Weber
So you're saying that my complaint about "if I build all targets in the
headless config, some don't build" should be sent to the headless team
instead of to this list?

I apologize for not necessarily replying particularly well.
But yes, that's what I was trying to say. There is an entire headless
Chrome build that has nothing to do with ozone. I think the targets that
you list are from that.
There is also an ozone platform implementation called "headless". It is
unrelated. If you find issues in the ozone platform implementations, you
can assign them to me and I'll direct them appropriately. But issues with
the headless target should go to the headless team.
Rob.

Post by Nico Weber

Post by Robert Kroeger
Ozone is a abstraction layer with multiple backends -- very much like
our GL implementation in some ways. There consequently many targets that
use ozone where each one could use one of several different ozone
implementations. The linux ozone and CrOS ozone bots probably capture the
most targets that use ozone.
Unfortunately, there is no Chrome builder that actually runs all of the
different ozone backends.
Rob.

Post by Nico Weber
Hi,
I'm trying to enable -Wimplicit-fallthrough for use_ozone=true builds
(it even finds bugs: https://chromium-review.
googlesource.com/c/chromium/src/+/899984)
So I enabled the warning locally, set use_ozone=true, and ran `ninja
-C out/gnozon`.
However, that seems to build a bunch of targets that aren't supposed
to be built (which is imho a bug; if someone were to clean this up by
removing references to targets that aren't supposed to build in this config
from //BULD.gn that'd be good. I'd file a bug, but I didn't see an "ozone"
component on crbug, so I wasn't sure if anyone would see it).
So then I used what the headless bot uses, which is "headless:headless
headless:headless_browsertests headless:headless_example
headless:headless_shell headless:headless_unittests headless_browsertests
headless_unittests"
However, this didn't build vr_shell, which was one of the targets that
does build and where the warning did find a bug.
How do I build all targets that are supposed to be part of an ozone build?
Thanks,
Nico